rust-num / num-integer

Integer trait and functions for Rust
Apache License 2.0
180 stars 48 forks source link

Correct documentation for gcd #50

Closed ciphergoth closed 2 years ago

ciphergoth commented 2 years ago

gcd asserts that the result is "always positive", but the result is (correctly) zero if both parameters are zero, so replace "positive" with "non-negative".

(Zero is correct here because 0Z + 0Z = 0Z where Z is the integers)

cuviper commented 2 years ago

Thanks!

bors r+

bors[bot] commented 2 years ago

Build succeeded: