rust-openvr / rust-openvr

OpenVR bindings for rust.
MIT License
165 stars 37 forks source link

State of maintainership? #57

Open Ybalrid opened 8 months ago

Ybalrid commented 8 months ago

Hello πŸ‘‹

I've been reading the discussions surrounding this rust library, and, as far as I understand, there are no plans from the org to do any significant work to these OpenVR bindings. (c.f.: https://github.com/rust-openvr/rust-openvr/pull/47#issuecomment-1025366777)

Currently, this crate is helpful but technically needs to be updated with Valve's current version of the OpenVR SDK. It also needs to be completed (lacking support for a number of still useful graphics API. e.g., Direct3D 11, see #56). There is also a large number of forks with potentially useful patches that are not contributing upstream (the joys of free and open source software in the era of GitHub, I guess πŸ˜‰)

I understand that OpenXR is available, but some people want to concentrate their efforts there. But OpenVR is still the main API to access several functionalities of SteamVR that are not provided by the OpenXR 1.0 standard notably:

Thus, IMHO the idea that OpenVR is not useful anymore is incorrect. I understand that the maintainer's interest might have switched from using OpenVR to instead using OpenXR, and that's perfectly fine! πŸ™‚

I'd like to have some clarity on the state of the future of this crate and eventually offer some help in keeping it up-to-date / implementing missing functionalities... πŸ€”

(Context: we're looking at Rust at my day job for a number of things. I work for a company in the XR space that still heavily uses SteamVR and OpenVR in its products for a number of the reasons listed above...)

Ralith commented 8 months ago

This crate is not maintained. It sounds like you have some compelling applications for it; perhaps you'd like to take on maintainership yourself? I don't have credentials for that, but hopefully whoever does can be tracked down.

I also encourage you/your employer to work with Khronos directly to try to get these gaps addressed in OpenXR itself as a more sustainable long-term solution.

Ybalrid commented 8 months ago

This crate is not maintained. It sounds like you have some compelling applications for it; perhaps you'd like to take on maintainership yourself? I don't have credentials for that, but hopefully whoever does can be tracked down.

I figured that out, and that issue is kind of a proposal for it

I also encourage you/your employer to work with Khronos directly to try to get these gaps addressed in OpenXR itself as a more sustainable long-term solution.

Yes, We (LIV Inc.) are part of the OpenXR working group. I cannot comment on the internals of the discussions that occur there. However, you can probably imagine that committee/standardization work is a very long process; And reaching a consensus with all the parties involved is not always an easy thing. πŸ™‚

Ybalrid commented 7 months ago

I don't have credentials for that, but hopefully whoever does can be tracked down.

I suppose that @reneeichhorn may be the person to talk to?

reneeichhorn commented 7 months ago

Hello @Ybalrid Sorry for the late response, looks like I only receive notifications when directly mentioned. So generally like you mentioned I'm no longer in need of the crate myself and hence I didn't spend any time on it. I also agree that OpenVR is still a viable choice for some projects despite the existence of OpenXR, so if you want to take ownership & maintance of this crate I'm happy to provide you all permissions (Github Org + crates.io)

So just to confirm again you are interessted in becoming a maintainer correct?

Ybalrid commented 7 months ago

Hello @Ybalrid Sorry for the late response, looks like I only receive notifications when directly mentioned. So generally like you mentioned I'm no longer in need of the crate myself and hence I didn't spend any time on it. I also agree that OpenVR is still a viable choice for some projects despite the existence of OpenXR, so if you want to take ownership & maintance of this crate I'm happy to provide you all permissions (Github Org + crates.io)

So just to confirm again you are interessted in becoming a maintainer correct?

Yes I am, I'll be glad to take care of the OpenVR Rust bindings!πŸ™‚

reneeichhorn commented 7 months ago

Thanks a lot for taking care πŸ‘πŸ» You should have got two invitation, with that you should be also able to publish to crates.io. Let me know if you need anything else

Ybalrid commented 7 months ago

Thanks!

Ybalrid commented 7 months ago

@reneeichhorn Hello again, I seem to not have the rights on the other repositories from the org? I may have to get started getting updates done on the sys crate, as I want to bring this up to speed with the most recent OpenVR version.

Also, that struct alignment issue regarding padding with bindgen is quite strange, I am very curious about what is going on there...

Ybalrid commented 7 months ago

Also, I am pretty sure we should remove, or change the avatar/logo of this org to something else, as I recall something about recent trademark policy changes

reneeichhorn commented 6 months ago

You should have full permission now. And yes agree on the logo, removed it for now

kaitlynkittyy commented 4 months ago

Is the project still planned to be maintained? The last commit shows as having been about 2 years ago.