rust-or / highs

Safe rust bindings to the Highs MILP Solver.
https://crates.io/crates/highs
MIT License
20 stars 12 forks source link

Build CI on macos-latest #11

Closed Coloquinte closed 10 months ago

Coloquinte commented 10 months ago

Highs doesn't build using Github CI on macos-latest (see complete log).

The error is ld: library not found for -lomp, which seems related to this stackoverflow thread, where the proposed solution is to provide the full path for libomp.dynlib.

I have no idea how to make this work transparently when installing the crate, but it would be nice to have.

lovasoa commented 10 months ago

Yes, that would be nice to have indeed! Can you make a pull request?

jajhall commented 10 months ago

HiGHS doesn't need OpenMP - and hasn't for 2-3 years

lovasoa commented 10 months ago

Wow, then we should probably update https://github.com/rust-or/highs-sys/blob/master/build.rs

@jajhall , could you have a look and check whether there are other things we should update there ?

Coloquinte commented 10 months ago

So if we don't need to build with OpenMP at all maybe we can just remove the cargo:rustc-link-lib=dylib=omp option from the highs-sys crate.

At the moment my workaround to build is the same as for highs-sys, using brew link --force libomp

jajhall commented 10 months ago

Wow, then we should probably update https://github.com/rust-or/highs-sys/blob/master/build.rs

@jajhall , could you have a look and check whether there are other things we should update there ?

Could you have a quick look through this please, @galabovaa?

Coloquinte commented 10 months ago

Trying this right now

Coloquinte commented 10 months ago

Great, thanks!