aml_tester: Real-world AML sometimes causes panic due to use of handler

rust-osdev / acpi

Rust library for parsing ACPI tables and interpreting AML

Apache License 2.0

203 stars 65 forks source link

aml_tester: Real-world AML sometimes causes panic due to use of handler #144

Closed rw-vanc closed 1 year ago

rw-vanc commented 1 year ago

Real-world AML can cause handler.read_u16, which is unimplemented and therefore causes aml_tester to panic. I'm not sure what the correct solution is, but perhaps just print a message and return 0?

IsaacWoods commented 1 year ago

:+1: Yep, this would almost definitely be better. Writes should probably also log but be no-ops.