search

rust-osdev / bootimage

Tool to create bootable disk images from a Rust OS kernel.
Apache License 2.0
767 stars 67 forks source link

Build bootloader with the features from the dependency #18

Closed IsaacWoods closed 6 years ago

IsaacWoods commented 6 years ago

This passes the features defined in the user's bootloader dependency to cargo-xbuild when we build the bootloader. It also errors if the user tries to specify features when using a precompiled bootloader, as we don't actually recompile the bootloader so it won't include those features.

phil-opp commented 6 years ago

Thanks a lot! I haven't tried it yet but it looks good to me.

Perhaps we should also handle the default features key. It would be confusing that enabling features works but disabling default features does not.

IsaacWoods commented 6 years ago

Ah yep, missed that. I've also tested locally and this now appears to work in all the cases I could think of

phil-opp commented 6 years ago

Thanks you!

phil-opp commented 6 years ago

Released as version 0.5.3