search

rust-osdev / bootloader

An experimental pure-Rust x86 bootloader
Apache License 2.0
1.36k stars 206 forks source link

Fixed "jc fail" instructions not working properly and updated README.md #453

Closed spencer3035 closed 1 month ago

spencer3035 commented 1 month ago

I noticed that the times where "jc fail" asm instructions are called are not behaving as expected. They need to be "call fail" in order for the stack to be set up properly to print the fail character. This can be reproduced by changing the jc to jnc and running in qemu.

I added a label in the boot.s that just calls the rust "fail" function and it seems to work as expected now.

I also updated the readme and fixed some error codes that were not unique.

spencer3035 commented 1 month ago

I addressed the recommended changes in this new commit. I can squash into one commit if you would like.