search

rust-osdev / bootloader

An experimental pure-Rust x86 bootloader
Apache License 2.0
1.39k stars 212 forks source link

new issues in blog os repo #454

Closed bingmatv closed 2 months ago

bingmatv commented 2 months ago

https://github.com/phil-opp/blog_os/issues E.g., an issue says there may be a typo "444" in the 3rd edition.

Freax13 commented 2 months ago

That's unrelated to this repo, so I'm closing this.

A small piece of advice: If you notice a typo and want to get it fixed, opening a PR is probably a better strategy than opening an issue. We all lead busy lifes and just pushing the merge button is a lot less effort on the maintainer's part rather than fixing the typo themselves (fixing it themselves probably requires them to at least check out the repo, fetch the latest changes, stash WIP changes, checking out the latest main branch, create a new branch, fix those typos and then creating a pull request). Fixing typos yourself is also a nice and pretty easy way to start contributing to a project and get more involved :smiley:

bingmatv commented 2 months ago

unrelated to this repo

Why did phil-opp post something in https://github.com/rust-osdev/bootloader/issues/299 ?

phil-opp commented 2 months ago

Sorry for not getting to your issues earlier! Feel free to ping me in the issue thread or on our zulip chat if you don't get a reply for a long time. However, please don't open additional issues like this one in other, unrelated repositories. It just creates additional work for us.