search

rust-osdev / cargo-xbuild

Automatically cross-compiles the sysroot crates core, compiler_builtins, and alloc.
Apache License 2.0
260 stars 25 forks source link

Don't print warning about missing root package in quiet mode. #79

Closed Nils-TUD closed 4 years ago

Nils-TUD commented 4 years ago

There does not seem to be a way to avoid that warning if a workspace is used. So, allow the user to disable the warning by passing --quiet to cargo-xbuild.

phil-opp commented 4 years ago

Thanks for the PR!

One way to avoid the warning is to make the workspace root a package too, e.g. by creating an empty lib.rs and adding a package section to the root Cargo.toml. This way, cargo-xbuild can read its config from that root Cargo.toml.

I still agree that we shouldn't print the warning in quiet mode.

phil-opp commented 4 years ago

Published as v0.5.33.

Nils-TUD commented 4 years ago

One way to avoid the warning is to make the workspace root a package too, e.g. by creating an empty lib.rs and adding a package section to the root Cargo.toml. This way, cargo-xbuild can read its config from that root Cargo.toml.

Ah okay. I'll keep that in mind for the case that I need to change config options for cargo-xbuild :)