rust-osdev / cargo-xbuild

Automatically cross-compiles the sysroot crates core, compiler_builtins, and alloc.
Apache License 2.0
258 stars 25 forks source link

Apply escape only on windows. #8

Closed AxelMontini closed 6 years ago

AxelMontini commented 6 years ago

Apply the escape only on windows, since it doesn't work on unix systems due to the escape sequence itself containing a space character. This is a pull request to update the "escape-spaces-in-rustflags" and finally fix the issue on Windows. The issue persists on Unix systems and it's not easy to solve. Anyways, paths containing whitespaces are uncommon on linux. Tested on windows and should just work on linux, since no modifications are applied to the string.

phil-opp commented 6 years ago

Thanks a lot!