search

rust-osdev / uart_16550

Minimal support for uart_16550 serial output.
MIT License
30 stars 23 forks source link

x86: crate finally builds with x86 and x86_64 #29

Closed phip1611 closed 11 months ago

phip1611 commented 12 months ago

This PR enables to actually use the crate with arch x86 and not just x86_64. I added CI steps to verify the build. It is a follow up to #28. I had to remove the x86_64 dependency as it broke the build.

Unfortunately, I had to remove your nice and convenient port abstraction from the x86_64 crate. As the ports are an internal API and not exposed to users, I think this is fine. However, it was not my intention to remove any of your work.. perhaps, you might have an idea for another/better solution?

phil-opp commented 12 months ago

Thanks for the PR! Could you

I had to remove the x86_64 dependency as it broke the build.

Could you give some more details on this?

phip1611 commented 11 months ago

The x86_64 crate doesn't build with x86 for many reasons. I don't think it is possible to fix the x86_64 crate in a sensible way.

image

phil-opp commented 11 months ago

Published as v0.3.0.

(This should be a non-breaking change. I still decided to do a new minor release in case there are some subtle differences in the API.)

phip1611 commented 11 months ago

Nice, thanks for merging this!