search

rust-osdev / ucs2-rs

UCS-2 conversion utilities for Rust.
Mozilla Public License 2.0
6 stars 5 forks source link

move CStr8, CStr16, and CString16 from uefi to ucs2 #23

Open phip1611 opened 3 months ago

phip1611 commented 3 months ago

This moves the CStr8, CStr16, and CString16 types from uefi to ucs2. The import is a 1:1 copy, but minor adjustments had to be made to be compatible with the new crate structure.

It may be a little inconsistent to have Cstr8 for Latin 1 UEFI strings here, however. What do we want to do with that? We could rebrand the crate to "UEFI strings", and not just UCS2?

phip1611 commented 3 months ago

This is my first version, @nicholasbishop . What do you think? I think moving this out of the uefi crate is beneficial. If you like the direction, I can streamline it further.

nicholasbishop commented 3 months ago

I think this is a good direction. Re CStr8, I think we should just keep it in the uefi crate.