search

rust-osdev / uefi-rs

Rusty wrapper for the Unified Extensible Firmware Interface (UEFI). This crate makes it easy to develop Rust software that leverages safe, convenient, and performant abstractions for UEFI functionality.
https://rust-osdev.com/uefi-book
Mozilla Public License 2.0
1.27k stars 153 forks source link

Consider periodically running CI on the current released version of the packages #343

Closed nicholasbishop closed 2 years ago

nicholasbishop commented 2 years ago

Since uefi-rs is used with the nightly compiler, sometimes the released versions of the packages suddenly stop compiling when changes to the compiler hit the nightly channel. See https://github.com/rust-osdev/uefi-rs/issues/339 for an example.

To some extent we should already know when this happens, since usually the master branch will also break, but it would still be nice to have a reminder in the form of periodic "CI failed" emails.

GabrielMajeri commented 2 years ago

Since https://github.com/rust-osdev/uefi-rs/pull/337 will make the template project use the published versions of the crate, and since we build the template in CI, maybe this will be enough?

nicholasbishop commented 2 years ago

I think that would not work because of the patch.crates-io section in the root crate. That overrides crates.io deps to use the local version instead. Which I think is not a bad thing, since otherwise we could accidentally break compilation of the template against master, just not sufficient to cover this use case.