rust-osdev / x86_64

Library to program x86_64 hardware.
https://docs.rs/x86_64
Apache License 2.0
797 stars 132 forks source link

set repr to transparent for various types #402

Closed Freax13 closed 1 year ago

Freax13 commented 1 year ago

Now that the representation is fixed, these types can be embedded into other structures such as AMD's VMCB and VMSA or Intel's ATTRIBUTES (SGX).

phil-opp commented 1 year ago

We should bump our bitflags dependency to v1.3 though. Earlier versions don't mention that repr(transparent) is valid.

Freax13 commented 1 year ago

We should bump our bitflags dependency to v1.3 though. Earlier versions don't mention that repr(transparent) is valid.

Good catch, thanks! Better be safe than sorry!