search

rust-osdev / x86_64

Library to program x86_64 hardware.
https://docs.rs/x86_64
Apache License 2.0
797 stars 132 forks source link

Set minimal scoped permissions to github workflow #411

Closed joycebrum closed 1 year ago

joycebrum commented 1 year ago

I would like to suggest to x86_64 project to adopt minimally scoped permissions on the github workflows.

I've made a similar change to the Volatile project https://github.com/rust-osdev/volatile/issues/32.

The reason to do that is to avoid the default github workflow behavior of granting write all permission to all workflows.

I'll submit a PR together with this issue. Let me know any questions or concerns you might have.

josephlr commented 1 year ago

@phil-opp we should also update the default permissions for either this repo or the entire rust-osdev organization.