search

rust-pcap / pcap

Rust language pcap library
Apache License 2.0
620 stars 144 forks source link

Add features test for ubuntu and macos platforms / optimize num of jobs #129

Closed sekineh closed 4 years ago

sekineh commented 4 years ago

Closes #123

I also reduced/optimized the number of jobs.

sekineh commented 4 years ago

@Wojtek242 I think Github Actions now includes all the duty travis performed. Please review.

Trolldemorted commented 4 years ago

Is the amount of jobs a problem? Without beta&nightly testing on macos and windows you are blind to upcoming regressions.

Wojtek242 commented 4 years ago

Is the amount of jobs a problem? Without beta&nightly testing on macos and windows you are blind to upcoming regressions.

Good question. The amount of jobs was definitely an issue for Travis which only ran 5 jobs at a time and the MacOS jobs each took 5 minutes. However, GitHub actions seem to be faster so probably not as much of a problem.

The question of whether to test stable, beta, and nightly is different. I'm actually not a big fan of testing on nightly, because I don't really want to commit time to fixing nightly-only issues, especially since I have been always avoided the nightly toolchain. Testing on beta is valuable though as it does help spot upcoming regressions.

Trolldemorted commented 4 years ago

Good question. The amount of jobs was definitely an issue for Travis which only ran 5 jobs at a time and the MacOS jobs each took 5 minutes. However, GitHub actions seem to be faster so probably not as much of a problem.

Yeah travis is slow as hell, github actions allows 20 concurrent jobs. Macos and ubuntu are <1min per test, windows is sluggish because installing winpcap takes forever.

The question of whether to test stable, beta, and nightly is different. I'm actually not a big fan of testing on nightly, because I don't really want to commit time to fixing nightly-only issues, especially since I have been always avoided the nightly toolchain. Testing on beta is valuable though as it does help spot upcoming regressions.

Consider yourself lucky, I have had a lot of dependencies that don't compile with stable/beta :|

How often do you expect failing nightly builds that require manual interaction?

sekineh commented 4 years ago

Overall, I feel like guilty when I put many jobs/minutes. Github/MS is paying machine/electricity cost and it's not clear they are sustainably profitable. If they see too much cost, they will have to re-think their strategy. So I want to focus on the supported platforms.

How often do you expect failing nightly builds that require manual interaction?

I already met a nightly failure and needed to re-run the job manually. It's workable but adds an extra step (+ wait time).

sekineh commented 4 years ago

@Wojtek242 I think I have fixed it. Could you please merge (Squash and merge) this PR#?