search

rust-pcap / pcap

Rust language pcap library
Apache License 2.0
620 stars 144 forks source link

Consistent code formatting #142

Closed Wojtek242 closed 3 years ago

Wojtek242 commented 4 years ago

Basically, just run rustfmt on the code as long as we agree on the settings. I propose to start with the default and go from there.

Also needs to be added to CI to ensure new PRs don't break formatting.

Wojtek242 commented 4 years ago

Best to leave this one as the last issue before 0.8.0 as otherwise it will create conflicts with existing PRs some of which we might want to merge.

Stargateur commented 3 years ago

I strongly support this, it's really annoying to work on a project where you can't rustfmt, that say I have no problem to have a rustfmt.toml to configure it as owner please

Best to leave this one as the last issue before 0.8.0 as otherwise it will create conflicts with existing PRs some of which we might want to merge.

That not a big work to merge this kind of change, you just need to do a rustfmt yourself before rebase, don't worry to much and do it :p. (there will always be alive PR so it's a never end problem)

Would be great to add a verification to not accept pull request that are not rustfmt too.