examples/getdevices.rs now just lists devices

rust-pcap / pcap

Rust language pcap library

Apache License 2.0

620 stars 144 forks source link

examples/getdevices.rs now just lists devices #156

Closed stappersg closed 3 years ago

stappersg commented 3 years ago

Replaced capture code with a pointer to a "how to". Reason for not doing a capture on each device, is because it waits forever on devices without network traffic.

This change also makes the example competable with the project feature of "list devices".

stappersg commented 3 years ago

CI results

19 cancelled, 10 successful, and 2 failing checks

are better has the

24 cancelled, 3 failing, and 4 successful checks

from previous pull request (#155)

For the clippy complains there is issue #157 created.

Wojtek242 commented 3 years ago

Looks good to me. I thing the getdevices.rs example is more useful this way.

Can I just ask you to rebase on master which now has the clippy issue fixed so that the CI pipeline can run before it gets merged?

stappersg commented 3 years ago

On Sun, Jan 24, 2021 at 01:41:52PM -0800, Wojciech Kozlowski wrote:

Can I just ask you to rebase on master which now has the clippy issue fixed so that the CI pipeline can run before it gets merged?

scheduled

stappersg commented 3 years ago

scheduled

It became #161, closing this merge request.