search

rust-pcap / pcap

Rust language pcap library
Apache License 2.0
620 stars 144 forks source link

`stream` feature/module does not work on Windows #201

Closed fu5ha closed 2 years ago

fu5ha commented 2 years ago

The stream module does not compile on Windows, and its current implementation seems relatively tightly tied to unix-only structures. I didn't see that documented anywhere and was confused when I got hit with errors on build.

sekineh commented 2 years ago

Readme.md says

Use the capture-stream feature to enable support for streamed packet captures. This feature is supported only on ubuntu and macosx.

Better documentation could be possible, I guess.

stappersg commented 2 years ago

On Tue, Feb 22, 2022 at 05:19:41AM -0800, Hideki Sekine wrote:

Better documentation could be possible, I guess.

Stop guessing and come back with merge requests.

sekineh commented 2 years ago

I think PRs are welcome as in usual practice.

stappersg commented 2 years ago

On Tue, Feb 22, 2022 at 05:38:18AM -0800, Hideki Sekine wrote:

I think PRs are welcome as in usual practice.

Okay, stop thinking and come back with PRs.

sekineh commented 2 years ago

Please feel free to send your PR.

stappersg commented 2 years ago

Yes, we agree that somebody (else) should do it.

Wojtek242 commented 2 years ago

@stappersg

Stop guessing and come back with merge requests.

Perhaps you didn't intend it tom come off as rude, but it did. I don't think this was called for.

As @sekineh has pointed out, the lack of support is documented in the README and I think that is sufficient for the time being.