search

rust-pcap / pcap

Rust language pcap library
Apache License 2.0
620 stars 142 forks source link

Feature capture-stream doc is not build on https://docs.rs/pcap/ #205

Closed Stargateur closed 2 years ago

Stargateur commented 2 years ago

It would be better to build with all features in general doc.

[package.metadata.docs.rs]
all-features = true

BTW, we use docs-rs features for build.rs when we should probably use env or at least use standard docsrs feature https://docs.rs/about/builds#detecting-docsrs

stappersg commented 2 years ago

@Stargateur is #206 what you mean?

If so: Make a merge request with better commit message as mine MR and which has you as committer.

Stargateur commented 2 years ago

exactly thus I don't know if it would compile on docs.rs

stappersg commented 2 years ago

On Wed, Apr 06, 2022 at 03:45:44AM -0700, Antoine wrote:

exactly thus

Acknowledge

I don't know if it would compile on docs.rs

Still transform your idea in merge request (and close this issue)