search

rust-pcap / pcap

Rust language pcap library
Apache License 2.0
598 stars 138 forks source link

Wincrate #238

Closed qrnch-jan closed 1 year ago

qrnch-jan commented 2 years ago

Use the windows-sys crate rather than winapi. Right now we're in the unfortunate situation where building Windows applications in Rust tends to eventually pull in multiple Windows API wrappers. It seems like the current trend is to convert projects to use windows{-sys} (since it's actively developed and supported by Microsoft).

qrnch-jan commented 2 years ago

Is the MSRV issue merely a documentation issue? Should it be noted in README.md that Windows, without capture-stream, builds require >= 1.46.0?

sekineh commented 2 years ago

Is the MSRV issue merely a documentation issue? Should it be noted in README.md that Windows, without capture-stream, builds require >= 1.46.0?

In addition to README.md, you’ll need to add an entry in CHANGELOG.md. You also have to tweak CI matrix (.GitHub/workflows) to exclude some conditions or to add 1.46.0 testing.

As far as I know, MSRV serves two purpose, 1) Some major distribution (e.g. Debian) is still pinned to the older rust version. 2) Want to avoid compile error without prior notice.

In my opinion, Windows users are happy to update their rust version, if documented clearly. (Compared to LTS distributions)

Please add comment if I missed something.

qrnch-jan commented 2 years ago

I updated the changelog and the readme, but I have never used github workflows before, so I'm fairly certain I borked something.

Wojtek242 commented 1 year ago

Merged manually due to merge conflicts with sendqueue