search

rust-pcap / pcap

Rust language pcap library
Apache License 2.0
595 stars 138 forks source link

more simple way to run ci for windows #266

Closed Stargateur closed 1 year ago

Stargateur commented 1 year ago

Quite ugly but should work as long as winpcap "official" installer. Honestly, that good enough for windows :p

Stargateur commented 1 year ago

I'm telling you I'm seriously consider dropping windows test support...

Stargateur commented 1 year ago

maybe:

          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116

https://github.com/chocolatey-community/chocolatey-packages/tree/master/automatic/winpcap is really dirty from what I understand there is not really any check or anything, if install is not done in 30s too bad ! maybe with 7 install the risk to fail install would be ok....

Wojtek242 commented 1 year ago

maybe:

          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116
          cinst -y winpcap --version 4.1.3.20161116

https://github.com/chocolatey-community/chocolatey-packages/tree/master/automatic/winpcap is really dirty from what I understand there is not really any check or anything, if install is not done in 30s too bad ! maybe with 7 install the risk to fail install would be ok....

Rather than trying cinst N times, one could always wrap it in a while loop of some sort and proceeding if the DLL does not exist

Wojtek242 commented 1 year ago

Thanks for your efforts! This motivated me to reach out to npcap as per #134 and now we have npcap for windows CI #273