search

rust-pcap / pcap

Rust language pcap library
Apache License 2.0
619 stars 142 forks source link

Intermittent Windows CI failures #275

Open Wojtek242 opened 2 years ago

Wojtek242 commented 2 years ago

https://github.com/rust-pcap/pcap/runs/8200995220?check_suite_focus=true

Every now and then a windows CI test will fail with (exit code: 0xc0000135, STATUS_DLL_NOT_FOUND). I originally assumed that it must be the wpcap.dll since that's the only one we are installing and it was installed via autohotkey which felt like a windows hack to install an exe silently. However, now the CI runs with Npcap OEM silent installer so it seems much less likely that that was the culprit.

Googling around a bit, one thing about STATUS_DLL_NOT_FOUND is that it does not indicate which DLL failed so perhaps it is not wpcap.dll. However, I don't know how to diagnose this from the CI.

I think for starters it would help if we would run DUMPBIN /DEPENDENTS (https://docs.microsoft.com/en-us/cpp/build/reference/dumpbin-command-line?view=msvc-170) on the test binaries and verify their existence manually in each CI run before running the test.

Wojtek242 commented 1 year ago

Not so intermittent anymore https://github.com/rust-pcap/pcap/actions

Wojtek242 commented 7 months ago

For now this problem is stopgapped by not running integration tests and instead relying on unit tests alone.

Wojtek242 commented 5 months ago

Some hope for 1.78/1.79?

Wojtek242 commented 5 months ago

Nope, still happens: https://github.com/rust-pcap/pcap/actions/runs/8936617851/job/24547312634