rust-pcap / pcap

Rust language pcap library
Apache License 2.0
619 stars 142 forks source link

Replace occurrences of "wpcap" with "npcap" to reduce confusion. #279

Closed grantshandy closed 1 year ago

grantshandy commented 1 year ago

As I understand it, wpcap (winpcap) is deprecated and hasn't been developed for some time, I'm also pretty sure it only supports a version of libpcap for 2009. Though winpcap has lots of api compatibility with npcap and probably works I think it's best that we direct people towards the actively developed npcap as is already done in the build directions for windows.

Ultimately I removed occurrences of wpcap in README.md here to reduce confusion as it tripped me up for a second on first reading.

stappersg commented 1 year ago

AIUI: code got s/wpcap/npcap/, now the README also.

The commit message is way to short.

grantshandy commented 1 year ago

No, I do understand that through Winpcap->Npcap the dll stayed as wpcap.dll. It wasn't my intention to write over any of that nuance. If this doesn't sound reasonable you can close the PR, I'm okay with that.

stappersg commented 1 year ago

Acknowledge

Regards Geert Stappers Linux user (a.k.a. NOT a windows user) Has not the privilege to close this merge request.

Wojtek242 commented 1 year ago

Thanks!