search

rust-pcap / pcap

Rust language pcap library
Apache License 2.0
595 stars 138 forks source link

Add `lending-iter` feature #294

Closed Stargateur closed 1 year ago

Stargateur commented 1 year ago

This show how GATs can be used for our problem that lifetime of paquet is link to capture lifetime. However, this is behind a lending-iter feature that I think should be considered not a part of our public api.

stappersg commented 1 year ago

image Now complete or still work in progress?

Wojtek242 commented 1 year ago

I finally got around to having a look. Thanks for the PR! Looks good to me. Just fix a few things for consistency and I will merge.

Oh, and please add a note to the CHANGELOG. After I merge, I will release 1.1.0 with this feature.

Stargateur commented 1 year ago

Oh, and please add a note to the CHANGELOG. After I merge, I will release 1.1.0 with this feature.

I already did no ?

Wojtek242 commented 1 year ago

Oh, and please add a note to the CHANGELOG. After I merge, I will release 1.1.0 with this feature.

I already did no ?

Ah, sorry. Yes, you did. It just occurred to me later and I didn't check.

Wojtek242 commented 1 year ago

Looks good to me. Thanks! I will merge now.