GATs have been stable for a while now, better iterators when?

rust-pcap / pcap

Rust language pcap library

Apache License 2.0

595 stars 138 forks source link

GATs have been stable for a while now, better iterators when? #297

Closed keogami closed 1 year ago

keogami commented 1 year ago

https://github.com/rust-pcap/pcap/blob/ff3eb2369dd5d6a2ba20063409bf4829a94aeabf/src/codec.rs#L6-L7

It really is an extreme pain to iterate over packets right now. But with GATs it should be a lot more present now.

Stargateur commented 1 year ago

https://github.com/rust-pcap/pcap/pull/294

stappersg commented 1 year ago

On Wed, May 03, 2023 at 09:35:35AM -0700, Keogami wrote:

Closed #297 as completed.

Is that a "#294 works for me" ???

If so, update #294

Stargateur commented 1 year ago

@stappersg you are now blocked my patience have limit. you are a pain in this project. You have done nothing in this project except being insulting.

keogami commented 1 year ago

I closed the issue cuz a PR is already open and I would prefer to discuss this issue further there. frankly, the PR seems a little bit lack luster but its good to see we are working to improve the iteration problem.

I just haven't made any comments yet because I don't call something bad without having concrete reasons and an alternative.

but, @Stargateur don't be this harsh on @stappersg lol