search

rust-pcap / pcap

Rust language pcap library
Apache License 2.0
594 stars 138 forks source link

Fix complaints from a 2021 clippy #313

Closed saethlin closed 7 months ago

saethlin commented 7 months ago

I was searching for discussion about this crate and happened to find someone who was confused by the implicit lifetimes. So I locally bumped the edition and looked at what cargo clippy complained about. They all seem like reasonable changes to me, and hopefully the explicit lifetimes help out future newcomers.

saethlin commented 7 months ago

Yup, that's what I was afraid of. The release of memchr 2.6.0 contained an MSRV bump, which means that this crate, unless something is done, has also changed its MSRV.

saethlin commented 7 months ago

Rebased so CI should have the MSRV lockfile

Wojtek242 commented 7 months ago

Thanks a lot!