search

rust-random / book

The Rust Rand Book
Other
49 stars 19 forks source link

Update the book #4

Closed dhardy closed 5 years ago

dhardy commented 5 years ago

Various changes to fill in the blanks and prepare for 0.6.

There are still a few short-comings of this doc, but at this point I feel I've written the lion's share of the book, so please consider writing a PR if you have contributions!

@vks would you like to work your xoshiro crate into this somehow? I did actually mention it in the update guide. (Or if you'd rather not mention it at this point or do something else with it, that's fine — rust-random is open to new crates.)

dhardy commented 5 years ago

Thanks. Some of it is just copy+paste though. Those links work for me (try mdbook build --open).

coltfred commented 5 years ago

@dhardy the links do work. Sorry about that.

vks commented 5 years ago

Looks very good! I only had a few minor comments.

@dhardy

would you like to work your xoshiro crate into this somehow? I did actually mention it in the update guide. (Or if you'd rather not mention it at this point or do something else with it, that's fine — rust-random is open to new crates.)

Sure, should I do the following?

  1. Open a PR adding a rand_xoshiro crate.
  2. Add xoshiro to the PRNG table.
dhardy commented 5 years ago

@vks I'd be happy to have rand_xoshiro merged here. The main advantage over a seperate rust-random/xoshiro crate would be getting the API doc in here.

Would you like to make a patch against this PR? You seem to have some idea what to say.

dhardy commented 5 years ago

@vks can you review https://github.com/rust-random/book/pull/4/commits/3af31882a29212cb638755fac86b99f98c128086 please?

vks commented 5 years ago

@dhardy

@vks can you review 3af3188 please?

Looks good! :+1: