rust-secure-code / cargo-supply-chain

Gather author, contributor and publisher data on crates in your dependency graph.
Apache License 2.0
313 stars 18 forks source link

Output should be consistently sorted #54

Closed Nemo157 closed 3 years ago

Nemo157 commented 3 years ago

In order to try and check how adding a dependency affected the overall tree I stored the before/after output into files and diffed it, unfortunately this resulted in the entire file appearing as changed because the order of crates in each line changed:

> cargo supply-chain publishers > before
> cargo add indicatif
> cargo supply-chain publishers > after
> diff -u before after
- 1. "github:rustwasm:core" via crates: wasm-bindgen-macro-support, web-sys, js-sys, wasm-bindgen-shared, wasm-bindgen, wasm-bindgen-macro, wasm-bindgen-backend
+ 1. "github:rustwasm:core" via crates: js-sys, web-sys, wasm-bindgen, wasm-bindgen-backend, wasm-bindgen-shared, wasm-bindgen-macro-support, wasm-bindgen-macro
Shnatsel commented 3 years ago

Ah, we sort most fields, but apparently this one evaded sorting. Let me fix that

Shnatsel commented 3 years ago

Fixed in 8843b0d47d970699849612ec7bb59b8795da4805. If you find anything else like that, please let me know!