search

rust-secure-code / cargo-supply-chain

Gather author, contributor and publisher data on crates in your dependency graph.
Apache License 2.0
313 stars 18 forks source link

Update cache timestamp only on success #58

Closed Shnatsel closed 3 years ago

Shnatsel commented 3 years ago

fixes #53

Shnatsel commented 3 years ago

Fair enough. Do you want to block the PR on that?

Also, since you wrote this, do you have any idea on what's the best way to structure it architecturally? Maybe have store write to a different dir and make another function commit that actually commits the cache?

Shnatsel commented 3 years ago

Fun fact: I made a bizarre optimization that brings down the download size for the cache from 350Mb to 60Mb, but it's kinda awkward to implement in the current architecture: https://github.com/rust-secure-code/cargo-supply-chain/tree/download-less

An approach to updating the cache that's explicitly two-phase would work better, I think.

Shnatsel commented 3 years ago

Right, I guess this will need a proper two-phase download then.

Shnatsel commented 3 years ago

Closing in favor of #60