Use `xdg` instead of `directories-next`; correct typo in directory name

rust-secure-code / cargo-supply-chain

Gather author, contributor and publisher data on crates in your dependency graph.

Apache License 2.0

313 stars 18 forks source link

Use `xdg` instead of `directories-next`; correct typo in directory name #96

Closed smoelius closed 4 months ago

smoelius commented 4 months ago

This PR has two commits:

The first replaces directories-next with xdg. (The former seems to have an uncertain future.)
The second corrects a typo I made in #93.

EDIT: I could make these two PRs, or scrap either change, if you prefer.

Shnatsel commented 4 months ago

The dependency change and typo fix look good. Why does this also rename a directory and update references to it?

smoelius commented 4 months ago

Why does this also rename a directory and update references to it?

In #93, I created a directory named dep_tests. But that directory is referenced by tests in a module called deps, not dep. Hence, the directory should rightfully be called deps_tests, not dep_tests.

Sorry to be OCD, but it has irked me. And since I was submitting a PR anyway, I thought I would fix it.

Shnatsel commented 4 months ago

I see. What is the typo fix? I cannot spot it in the diff.

Shnatsel commented 4 months ago

Also, CI fails. Please run rustfmt to format the code. If that doesn't help please let me know - it's possible that CI version of rustfmt is too old.

smoelius commented 4 months ago

I see. What is the typo fix? I cannot spot it in the diff.

Naming the directory dep_tests instead of deps_tests is what I am calling a "typo." The fix is to rename the directory to the latter. (Sorry for being unclear.)

Shnatsel commented 4 months ago

Ah I see. Thanks! Merging.