search

rust-secure-code / safety-dance

Auditing crates for unsafe code which can be safely replaced
Apache License 2.0
536 stars 10 forks source link

Audit lokacore #14

Closed Lokathor closed 5 years ago

Lokathor commented 5 years ago

Some sort of crazy idiot is claiming to have (trait bound) safe casting utilities for all sorts of stuff in their crate. Surely this is too good to be true, they must have screwed up somewhere.

https://github.com/Lokathor/lokacore

Shnatsel commented 5 years ago

https://crates.io/crates/lokacore has at about 1 download per day on crates.io. Could be too small fish to fry.

Lokathor commented 5 years ago

<3

but verified safe casting is a public good, and if we can convert people to using that instead of transmute all over the place that's a safety gain that can grow quite a bit over time

Shnatsel commented 5 years ago

I believe the safe type conversions have been split into a separate crate: https://crates.io/crates/bytemuck

This could come in handy as a safe abstraction, so auditing this is probably worthwhile.

Lokathor commented 5 years ago

Closing in favor of https://github.com/rust-secure-code/safety-dance/issues/43