Open evanjs opened 4 years ago
Shnatsel's pull request to replace smallvec with tinyvec was recently accepted, so that dependency is no longer a problem.
The decompose_hangul
unsafeness can be removed by simply replacing the from_u32_unchecked
function call with from_u32
, but that may have some unforeseen performance or behavioural consequences. It will pass the tests in the project however.
I can't see a way to avoid unsafe character creation there without a performance hit, but at least we could add debug assertions there and then plug this into a fuzzer to see if they actually hold.
unicode-normalization: GitHub, crates.io Another widely-used crate.
Discovered some unsafe expressions when checking url (#51).
Once again, no clue if any of these are safe.
Example unsafe usage in
decompose_hangul
.