rust-serverless / lambda-rust

🐳 🦀 a dockerized lambda build env for rust applications

MIT License

34 stars 8 forks source link

RFC: lambci v aws lambda repository as the base of the Dockerfile #13

Closed jerusdp closed 3 years ago

jerusdp commented 3 years ago

Proposal

Change from using:

FROM docker.io/lambci/lambda:build-provided.al2

to:

FROM public.ecr.aws/lambda/provided:al2-x86_64

Reasons

lambci image is not actively maintained
lambci requires a lengthy patch application during the build
aws lambda is the target image and actively maintained with security patches
builds are provided for both x86_64 and arm_64 (recently released for lambda)
security of the environment should be maintained by aws build (should we still run the security check?)

Approach

Update Dockerfile
Test etc. @ZaMaZaN4iK @micrictor @hans00 @Veetaha @tysg

zamazan4ik commented 3 years ago

From my point of view, that's a good idea:

Using actively maintained source image is better
Using a more secure by default image is better
Providing image for x86-64 and ARM architectures is better since Graviton-based Lambdas should be popular (that's my guess)
Regarding security checks - since these checks are free for us, we can still run them. If we will find any maintenance burden with them or any bugs - we can easily turn off them.

zamazan4ik commented 3 years ago

Closing it since it's done