rust-syndication / rss

Library for serializing the RSS web content syndication format
https://crates.io/crates/rss
Apache License 2.0
419 stars 52 forks source link

Adding item itunes:episodeType tag. #103

Closed mindreader closed 4 years ago

mindreader commented 4 years ago

One last tag. <itunes:episodeType>, which can be either "episodic" or "serial". If it is "serial", then apple mandates that you must have episode numbers on your episodes.

https://help.apple.com/itc/podcasts_connect/#/itcb54353390

codecov[bot] commented 4 years ago

Codecov Report

Merging #103 into master will increase coverage by 0.03%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   79.58%   79.62%   +0.03%     
==========================================
  Files          24       24              
  Lines        1739     1747       +8     
==========================================
+ Hits         1384     1391       +7     
- Misses        355      356       +1     
Impacted Files Coverage Δ
src/extension/itunes/itunes_item_extension.rs 85.18% <83.33%> (-0.15%) :arrow_down:
tests/read.rs 95.36% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b945f5e...d059963. Read the comment docs.

AnderEnder commented 4 years ago

@mindreader, if there are only 3 types, why String is used, I would expect Enum with 3 values.