search

rust-syndication / rss

Library for serializing the RSS web content syndication format
https://crates.io/crates/rss
Apache License 2.0
419 stars 52 forks source link

implement Atom extension #110

Closed andy128k closed 3 years ago

andy128k commented 3 years ago

Closes #30

codecov[bot] commented 3 years ago

Codecov Report

Merging #110 into master will decrease coverage by 0.89%. The diff coverage is 65.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   86.07%   85.17%   -0.90%     
==========================================
  Files          25       26       +1     
  Lines        1917     2003      +86     
==========================================
+ Hits         1650     1706      +56     
- Misses        267      297      +30
Impacted Files Coverage Δ
src/extension/mod.rs 71.42% <ø> (ø)
src/extension/atom.rs 42.10% <42.10%> (ø)
src/channel.rs 87.18% <63.63%> (-0.75%) :arrow_down:
src/item.rs 90.85% <63.63%> (-1.96%) :arrow_down:
tests/read.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1288abd...4a40c25. Read the comment docs.

kushaldas commented 3 years ago

I am wondering how much work is remaining on this feature? @andy128k any guess?

andy128k commented 3 years ago

@kushaldas According to a spec, having <atom:link/> is enough. So, feature-wise it is done.

I would like to have a feedback from other contributors to confirm the approach of depending on atom_syndication crate.

kitlith commented 3 years ago

@andy128k that's not a spec. That's a user guide. And it even says that "Any of these elements can be used in RSS by employing Atom as a namespace." But, as a user guide/best practices guide, it's pointing out the most useful/common elements.

That said, is it enough for an initial implementation? Probably. Tick the most common feature off. But it's not complete.

kushaldas commented 3 years ago

@kushaldas According to a spec, having <atom:link/> is enough. So, feature-wise it is done.

I would like to have a feedback from other contributors to confirm the approach of depending on atom_syndication crate.

I would love to see the rel="self" part, you can see the recommendation at https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fkushaldas.in%2Frss.xml