rust-syndication / rss

Library for serializing the RSS web content syndication format
https://crates.io/crates/rss
Apache License 2.0
426 stars 52 forks source link

Add xml declaration #113

Closed amoskvin closed 3 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #113 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   86.15%   86.16%           
=======================================
  Files          25       25           
  Lines        1921     1922    +1     
=======================================
+ Hits         1655     1656    +1     
  Misses        266      266           
Impacted Files Coverage Δ
src/channel.rs 87.93% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d8bd11...681ca6b. Read the comment docs.

amoskvin commented 3 years ago

Any concern with this one?

On Saturday 17 October 2020 17:50:29, Alec Moskvin wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/rust-syndication/rss/pull/113

-- Commit Summary --

  • Add xml declaration

-- File Changes --

M src/channel.rs (4)
M tests/data/verify_write_format.xml (1)

-- Patch Links --

https://github.com/rust-syndication/rss/pull/113.patch https://github.com/rust-syndication/rss/pull/113.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rust-syndication/rss/pull/113