rust-syndication / rss

Library for serializing the RSS web content syndication format
https://crates.io/crates/rss
Apache License 2.0
429 stars 53 forks source link

Correctly use atom:link instead of link for atom links #141

Closed NoraCodes closed 1 year ago

NoraCodes commented 2 years ago

<link rel="self> does not validate in https://validator.w3.org/feed, while this (<atom:link rel="self">) does.

codecov[bot] commented 2 years ago

Codecov Report

Merging #141 (1b001f7) into master (878bb2d) will increase coverage by 35.15%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master     #141       +/-   ##
===========================================
+ Coverage   45.14%   80.30%   +35.15%     
===========================================
  Files          26       24        -2     
  Lines        4357     1528     -2829     
===========================================
- Hits         1967     1227      -740     
+ Misses       2390      301     -2089     
Impacted Files Coverage Δ
src/extension/atom.rs 46.87% <0.00%> (-16.96%) :arrow_down:
src/extension/syndication.rs 72.72% <0.00%> (-3.08%) :arrow_down:
src/extension/itunes/itunes_channel_extension.rs 97.89% <0.00%> (-0.29%) :arrow_down:
src/error.rs 0.00% <0.00%> (ø)
src/extension/itunes/itunes_owner.rs 100.00% <0.00%> (ø)
src/extension/itunes/itunes_category.rs 100.00% <0.00%> (ø)
src/extension/itunes/itunes_item_extension.rs 100.00% <0.00%> (ø)
tests/write.rs
tests/read.rs
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

icewind1991 commented 2 years ago

To use the atom: prefix you'll need to define the atom namespace, such as by adding xmlns:atom="http://www.w3.org/2005/Atom" to the <rss> root tag