rust-syndication / rss

Library for serializing the RSS web content syndication format
https://crates.io/crates/rss
Apache License 2.0
419 stars 52 forks source link

Use rustfmt defaults, removed unneeded clones, cleaned up String conversions #37

Closed jameshurst closed 7 years ago

frewsxcv commented 7 years ago

Sorry to ask for this, but is it possible you could make these separate commits? it's very hard to tell what the changes are since the styling changed everything

jameshurst commented 7 years ago

Sure, I could do that.

frewsxcv commented 7 years ago

An easy way to do that could be to revert the old style file and just run cargo fmtagain on this commit

jameshurst commented 7 years ago

The odd thing is even when running cargo fmt with to old .rustfmt.toml I still get style changes from rustfmt. I'll split the rustfmt stuff out in to a different commit.

jameshurst commented 7 years ago

@frewsxcv I'm wondering what your opinion is on the inclusion of the reqwest library, as the function is serves here is trivial for a user to implement themselves but potentially many needed dependencies for a user who doesn't require it. My thought is that it should either be removed or put behind a feature gate.