Closed markpritchard closed 5 years ago
Hmm, that build passed when I built it locally (1.34.1). Will investigate!
Hi Corey,
Thanks for approving! I don't think they are breaking - the tests are basically unchanged, as is the API. The extension namespaces are no longer always added (e.g. dublincore) but they were superfluous anyway.
Cheers,
Mark
On Sun, May 12, 2019 at 7:10 AM Corey Farwell notifications@github.com wrote:
@frewsxcv approved this pull request.
Looks good! Are any of these changes considered breaking changes? Doesn't look like it...
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rust-syndication/rss/pull/78#pullrequestreview-236392661, or mute the thread https://github.com/notifications/unsubscribe-auth/AB62IVS2JBYIRM7V3UE32F3PU4Y5RANCNFSM4HK7RHHA .
I wanted to add support for the RSS Syndication module (http://purl.org/rss/1.0/modules/syndication/) which provides the period at which feeds are updated.
The standard uses the
sy
local prefix, whereas many feeds usesyn
so this PR also introduces dynamic local prefixes for namespaces.