search

rust-syndication / rss

Library for serializing the RSS web content syndication format
https://crates.io/crates/rss
Apache License 2.0
419 stars 52 forks source link

Remove dependency on failure #82

Closed SSheldon closed 4 years ago

SSheldon commented 4 years ago

This used to be a dependency of quick-xml, but it was removed in version 0.17 by tafia/quick-xml#170. rss depended on it previously to work with quick-xml::Error, but this is no longer necessary. Keeping it means rss is pulling in a lot of other unnecessary dependencies.

This change also updates to stop using the deprecated parts of std's Error trait.

SSheldon commented 4 years ago

Hmm, I just noticed that the sibling atom_syndication crate accepted a PR to replace failure with thiserror in rust-syndication/atom#17.

This handwritten code for the error is really not much, and it doesn't seem worth pulling in more dependencies to avoid it to me...

SSheldon commented 4 years ago

I took the liberty of including an updated from the deprecated Error APIs to bring this in-line with atom after the changes in rust-syndication/atom#18.

SSheldon commented 4 years ago

Now that rust-syndication/atom#18 has been merged, this change will bring the design of the errors in rss and atom in line.

Anything else I need to do before this can be merged?

frewsxcv commented 4 years ago

Anything else I need to do before this can be merged?

LGTM!