search

rust-syndication / rss

Library for serializing the RSS web content syndication format
https://crates.io/crates/rss
Apache License 2.0
419 stars 52 forks source link

Consider removal of `from_url` feature #84

Closed andy128k closed 4 years ago

andy128k commented 4 years ago
  1. Current API is not flexible enough (It is not possible to pass extra headers like ETag).
  2. Reqwest is a heavy dependency.
  3. Reqwest changed its main API to async one recently. Changing to this API will be a breaking change, but it will also bring tokio as a dev-dependency.
SSheldon commented 4 years ago

++. I think the feature brings negligible utility in comparison to the maintenance cost and overhead. As a user, it isn't much harder for me to pull in reqwest myself vs enable the feature.

If we're concerned that integrating between the two might be challenging, maybe the docs could just include a short code sample on how to fetch and read a Channel?