rust-syndication / rss

Library for serializing the RSS web content syndication format
https://crates.io/crates/rss
Apache License 2.0
426 stars 52 forks source link

Escape Guid value #98

Closed amoskvin closed 4 years ago

amoskvin commented 4 years ago

This is a fix for invalid xml generated if guid is a url with unescaped xml characters:

    <item>
      <link>https://example.com/?foo=7&amp;bar=11</link>
      <guid>https://example.com/?foo=7&bar=11</guid>
    </item>
codecov[bot] commented 4 years ago

Codecov Report

Merging #98 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files          24       24           
  Lines        1724     1724           
=======================================
  Hits         1371     1371           
  Misses        353      353           
Impacted Files Coverage Δ
tests/read.rs 95.30% <ø> (ø)
src/guid.rs 92.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b037d5...79c7422. Read the comment docs.

andy128k commented 4 years ago

LGTM