search

rust-transit / gtfs-structure

Read a GTFS file
MIT License
61 stars 32 forks source link

Better error message for wrong stop_id in transfers.txt #133

Closed fchabouis closed 1 year ago

fchabouis commented 1 year ago

...and pathways.txt

linked to https://github.com/etalab/transport-site/issues/2958

I was wondering if I was misusing the Error, just passing the filename with the stop_id like that?

But the error is used in other context, where the filename is not necessarily known, so maybe it is fine. Let me know :)

Thanks!

fchabouis commented 1 year ago

Clippy is not happy, but I don't undersand what I have changed to upset it for the moment. I could correct what it is complaining about, but why is it complaining now?

antoine-de commented 1 year ago

I have not checked, but I think it's due to clippy updates :stuck_out_tongue_winking_eye:

I can lend you a hand if they are difficult to change

fchabouis commented 1 year ago

I was lost, because I thought there would be a cargo.lock file to avoid automatic updates like that. But I read this and it makes sense.

antoine-de commented 1 year ago

hum, but here it's just the clippy version in CI that is not pinned isn't it? And even if it's a bit painful, I think it's nice to benefit from all the upgrades

fchabouis commented 1 year ago

I have applied the Clippy's suggestions