Use a Different Zip Crate for Decompression

rust-transit / gtfs-structure

Read a GTFS file

MIT License

61 stars 31 forks source link

Use a Different Zip Crate for Decompression #156

Open lolpro11 opened 8 months ago

lolpro11 commented 8 months ago

Hi, On PR #153 @Tristramg mentioned support of various zip compression methods that are not used in Zip. @kylerchin also mentioned the use of ~~LZMA~~ Nested Feeds in SEPTA's GTFS Feed. Do we have any ideas for an alternate crate? Thanks. Edit: Looks like no current GTFS provider has compressed their feed using anything other than store or deflate. https://github.com/rust-transit/gtfs-structure/pull/153#issuecomment-1931609596

kylerchin commented 8 months ago

The user should handle edge cases where there are nested zip libraries.

lolpro11 commented 8 months ago

The user should handle edge cases where there are nested zip libraries.

Example:

let (gtfs_bus, gtfs_rail) = GTFS::from_multizip()

Still user directed, but for cases like SEPTA where it might be useful for testing in cargo test A better idea would be returning a Vec with the GTFS structs because my example would only return the 2 GTFS structs.

kylerchin commented 8 months ago

It is a single agency and the library should not be changed to accommodate a single agency's poor file distribution.