Open dgunay opened 4 years ago
It may be more idiomatic to call these "session types", but the article I referenced calls them typestates.
Is this repo still maintained? @lambda-fairy
Not really. I think this repo needs someone with time & a vision to make it useful.
@dgunay Hey, thank you for your contribution! Could you please rebase your branch on master
please and link typestate.md
in SUMMARY.md
? We'll review this PR the upcoming days.
Status: I wrote the author an email, if he is fine with us taking some of his content and if he could relicense it and state it here somewhere in the repository. Until then we'll need to wait.
@dgunay Hey, thank you for your contribution! Could you please rebase your branch on
master
please and linktypestate.md
inSUMMARY.md
? We'll review this PR the upcoming days.
Hi, thank you @simonsan. I am currently unfamiliar with how to do rebases (have never done them yet). I see you merged master into patch-1 - do I still need to do anything?
git fetch
git rebase origin/master
... edit if there are confilcts
git add ...
git rebase --continue # do this as many times as needed
git push -f
@dgunay Hey, thank you for your contribution! Could you please rebase your branch on
master
please and linktypestate.md
inSUMMARY.md
? We'll review this PR the upcoming days.Hi, thank you @simonsan. I am currently unfamiliar with how to do rebases (have never done them yet). I see you merged master into patch-1 - do I still need to do anything?
No, I did it, so we let it check with the CI. I've made a small review, maybe you could address the suggestions questions in it for now? ;-) Thanks
Note that there are other method to have type state, like each one of the state as their own struct, which is more useful when different states have different types. If different states have different types but combined with this technique, there could easily be footguns.
Note that there are other method to have type state, like each one of the state as their own struct, which is more useful when different states have different types. If different states have different types but combined with this technique, there could easily be footguns.
Do you want to make some suggestions to change. I see a bit of a problem in that this is taken from another author as well. And I struggle a bit to reach the author. He answered me that we could link to his article and I should get back if linking is not an option for relicensing. So I wrote back that just linking the article is probably not the best way, if we want to keep it in the repository. But didn't receive an answer yet. So citation of some stuff might be fine in this regards, but just taking a lot from the article is not, I feel. So we might have to rewrite it nevertheless. Unless the author shows up here and states what he thinks (what he could, as I sent him a link to this PR).
I mean something like using struct
s to have types as state. Like from Letter { data: ... }
to ClosedLetter
to OpenedLetter
or something like that, I once read another article like this.
I believe we can add something like #227 here and fix that along since it is similar enough? Here it encodes the state as variable but that encodes it as a type (which I think is more preferable).
Closing in favour of #249
Reopening due to change of scope of #249
Neat pattern for Rust that lets you encode valid/invalid states using the type system.