search

rust-unofficial / patterns

A catalogue of Rust design patterns, anti-patterns and idioms
https://rust-unofficial.github.io/patterns/
Mozilla Public License 2.0
7.98k stars 363 forks source link

Add introduction #117

Closed simonsan closed 3 years ago

simonsan commented 3 years ago

Reviving the ghost PR #43

Regarding functional and refactoring folders:

Something that we might add to the issues:

I was thinking something similar to what exists in the patterns folder, probably with an altered template. So far my ideas are:

* `functional`

  * currying
  * higher-order functions
  * collections

* `refactoring`

  * refactoring from `unwrap` to `Result`
  * refactoring from `enum` to `Option`

Some point may still stand? Need to check.

2021-01-01 15_00_03-Window-Screenshot

Fixes #4

simonsan commented 3 years ago

Nice!

simonsan commented 3 years ago

@pickfire It's hard to deal with that feedback in a closed and merged PR. What do you think about changing the things directly in these files to your liking and create a new PR where we can discuss about your proposed changes? Would make it much easier to follow for everyone I think. Happy new year! ;)

pickfire commented 3 years ago

@pickfire It's hard to deal with that feedback in a closed and merged PR. What do you think about changing the things directly in these files to your liking and create a new PR where we can discuss about your proposed changes? Would make it much easier to follow for everyone I think. Happy new year! ;)

Happy new year!

I wish there is more time gap since I am interested to help review these too (of course only those that I am able to). I see that by the time I read it (within 1 or 2 day time) it was already merged. @simonsan How did you get to be the maintainer here? I remember that it wasn't active for a while and then you suddenly come and change.

simonsan commented 3 years ago

I wish there is more time gap since I am interested to help review these too (of course only those that I am able to). I see that by the time I read it (within 1 or 2 day time) it was already merged.

This PR was a ghost PR from October 2016, most of the PRs, beside the repository structure we are changing like setting up CI or creating a book, were relatively old PRs. We want to work down the list and create a great learning resource for the community with it because imho this is excellent content and it will get even better with more people participating in the future. The other left over PRs are much bigger topics than the ones that were merged, so there will be a timegap for sure. I'm thankful as well, if there are more eyes on it with reviews, please feel free to review them as well. The velocity will slow down soonish, as we handled most of the open PRs already.

@simonsan How did you get to be the maintainer here? I remember that it wasn't active for a while and then you suddenly come and change.

I think this is a good collection of what happened and an actual status: https://www.reddit.com/r/rust/comments/kowtqn/rust_design_patterns_now_also_as_a_book/

Cheers ;-)

MarcoIeni commented 3 years ago

Pickfire, feel free to leave a comment on a pr if you want to review it and we will wait for your review, even for different days, no problem! Right now I'm overwhelmed by github notifications, so any help is HIGHLY appreciated! :)

Me and simonsan requested maintainer rights in #107 by the way