rust-unofficial / patterns

A catalogue of Rust design patterns, anti-patterns and idioms
https://rust-unofficial.github.io/patterns/
Mozilla Public License 2.0
7.98k stars 363 forks source link

Add markdown linter in CI #119

Closed MarcoIeni closed 3 years ago

MarcoIeni commented 3 years ago

It would be nice to have something in CI that tells us if markdown is correct. For example this markdown is not valid:

# section 1

### section 2

Or stuff like: avoid tabs or detect trailing whitespaces.

simonsan commented 3 years ago

We could use this action for linting https://github.com/marketplace/actions/markdownlint-mdl-action

Not sure how complicated it is though to find a "style" that fits but at least tabs, whitespaces and the section headers should be easily setup.

MarcoIeni commented 3 years ago

Other ones I've found:

MarcoIeni commented 3 years ago

We have to choose between:

Thanks to the parameter "number of stars" the second option is winning at the moment :joy: Do you have any preference?

simonsan commented 3 years ago
* https://github.com/avto-dev/markdown-lint - uses https://github.com/DavidAnson/markdownlint

Seems better maintained and has the better documentation and tooling (e.g. VScodium extension) it seems

MarcoIeni commented 3 years ago

Nice, let's use that one. Who wants to start working on this can leave a comment here.

Takashiidobe commented 3 years ago

I'd like to work on this:

I propose doing a few things:

simonsan commented 3 years ago

I'd like to work on this:

I propose doing a few things:

* Running markdownlint on all markdown files in the project:

* Then setting up the the github action to check for markdown lint errors on PR.

Nice!