search

rust-unofficial / patterns

A catalogue of Rust design patterns, anti-patterns and idioms
https://rust-unofficial.github.io/patterns/
Mozilla Public License 2.0
7.95k stars 362 forks source link

fix internal links #143

Closed MarcoIeni closed 3 years ago

MarcoIeni commented 3 years ago

In this way they also work locally.

simonsan commented 3 years ago

we might be also able to solve this if we rename README.md in those folders to index.md? not sure though need to try it out

simonsan commented 3 years ago

That would also work it seems 🤔 @MarcoIeni Which one do you think is better. the index.md approach is github unfriendly because it doesn't automatically show the README on opening a folder. the initial version shows the readme but doesn't link on github 🤔

MarcoIeni commented 3 years ago

Let's go with index.md it is more clear because it converts to index.html

simonsan commented 3 years ago

Let's go with index.md it is more clear because it converts to index.html

Have you tested this change as well locally? For me it seems to work.

The disadvantage is all the open PRs that change something in these files will need to be revises, but it's fine I guess

simonsan commented 3 years ago

Ok, tested it again, should be fine. 👍🏽