search

rust-unofficial / patterns

A catalogue of Rust design patterns, anti-patterns and idioms
https://rust-unofficial.github.io/patterns/
Mozilla Public License 2.0
8.11k stars 375 forks source link

Deny warnings #47

Closed llogiq closed 7 years ago

llogiq commented 7 years ago

This fixes #46

llogiq commented 7 years ago

Oops, somehow messed up the history.

llogiq commented 7 years ago

I now rewrote most of the text, added a few allow lints for good measure and fixed history.

@nrc Thank you for the useful comments. I'm now much happier with this PR.

llogiq commented 7 years ago

Note to self: Perhaps I should link to the #[deprecate] docs, too.

llogiq commented 7 years ago

Ok, now I think this is ready to merge. Thoughts?

llogiq commented 7 years ago

Thanks @lfairy for the thorough read-through. This is becoming quite good now.

@nrc @lfairy r?

lambda-fairy commented 7 years ago

Looks good to me! I'll wait for any comments from @nrc before merging.

llogiq commented 7 years ago

@nrc ping?

nrc commented 7 years ago

LGTM, thanks for the changes!