search

rust-ux / uX

Non standard integer types like `u7`, `u9`, `u10`, `u63`, `i7`, `i9`
Apache License 2.0
121 stars 37 forks source link

Derive PartialEq, Eq, PartialOrd, Ord, Hash #68

Closed chrysn closed 4 months ago

chrysn commented 7 months ago

The derived implementations work now that the interior value is always fully masked (https://github.com/rust-ux/uX/pull/65).

As a side effect, this makes consts eligible for pattern matching.

Close: https://github.com/rust-ux/uX/issues/66

bbaldino commented 7 months ago

lgtm, just a formatting problem looks like

bbaldino commented 5 months ago

@chrysn you going to update this? Looks like it's just a style issue causing the failure

chrysn commented 5 months ago

Thanks for the nudge, fixed.

The branch is not "up to date before merging" as GitHub configs call it, but I don't think that's a necessary step if we enable merge queues. Mind if we enable that? Then we get both the branch-is-checked-to-work-with-latest-master property and the branch-starts-from-where-the-author-started-it property.

bbaldino commented 5 months ago

I haven't played with the merge queue stuff, but I'm fine with giving it a go.

AnthonyMichaelTDM commented 5 months ago

why not just update this branch?

bbaldino commented 4 months ago

@chrysn I found myself needing to match on uX types today...can we get this in? Could just rebase on top of master

bbaldino commented 4 months ago

@chrysn bump

chrysn commented 4 months ago

I've enabled the merge queue feature, which should give us a semantically correct merge history -- but for some reason the individual checks don't get kicked off. Therefore, disabling mere queues again, rebasing this branch. Not happy with this situation, but not investing too much time in understanding GitHub either.